Блог пользователя arnav2004

Why am I getting Runtime Error?
Автор arnav2004, история, 3 года назад, По-английски

I solving this problem Link to problem. I could not solve it hence checked other people's code. I saw this AC Code. AC Solution. I changed it just a little bit and it got runtime error. Runtime Error Code. As you can see the only difference is in the for loop in the 'dfs' function. Can anyone tell me the reason for the code to receive a runtime error.

  • Проголосовать: нравится
  • 0
  • Проголосовать: не нравится

»
3 года назад, # |
← Rev. 3   Проголосовать: нравится 0 Проголосовать: не нравится

.

→ Ответить
»
3 года назад, # |
← Rev. 2   Проголосовать: нравится +1 Проголосовать: не нравится

You should never delete element in a range-based for loop. In the AC code, the element are deleted later after the for loop. If you still wanna delete element while iterating:

for(auto it = s.begin(); it != s.end(); ){
    if(/*delete condition here*/) it = s.erase(it); //return the next iterator
    else ++it;
}

I still prefer to delete outside the loop than delete inside the loop. From my experience, set is a magic data structure in C++, sometime you couldn't find where your code cause RTE without printing every possible variables, debugger can't help. So be careful, otherwise you will have a great time debugging hopelessly.

→ Ответить
  • »
    »
    3 года назад, # ^ |
      Проголосовать: нравится 0 Проголосовать: не нравится

    Thanks for the info. Learnt something new.

    But still after iterating through iterators it's still giving runtime error. (This time on test 1). Here is the code that I wrote:

    for(auto x = unv.begin(); x != unv.end(); ) {
        if (bad.find(minmax(*x, v)) == bad.end()){
            int c = *x;
        	x = unv.erase(x);
        	dfs(c);
        }
        else x++;
    }
    → Ответить
    • »
      »
      »
      3 года назад, # ^ |
        Проголосовать: нравится +1 Проголосовать: не нравится

      Simply because unv is modified outside the loop. Assume currently we are in node u then Then we call dfs go to v and delete something in unv. When we go back to u, unv was modified.

      → Ответить
    • »
      »
      »
      3 года назад, # ^ |
        Проголосовать: нравится +1 Проголосовать: не нравится

      i have removed verdict RTE by first checking whether that element that you are iterating in loop is present or not, we are doing this because we have modified this set many times. 136610663

      → Ответить