Problem link : https://codeforces.net/contest/1620/problem/C
Submission link : https://codeforces.net/contest/1620/submission/162394549
№ | Пользователь | Рейтинг |
---|---|---|
1 | tourist | 4009 |
2 | jiangly | 3823 |
3 | Benq | 3738 |
4 | Radewoosh | 3633 |
5 | jqdai0815 | 3620 |
6 | orzdevinwang | 3529 |
7 | ecnerwala | 3446 |
8 | Um_nik | 3396 |
9 | ksun48 | 3390 |
10 | gamegame | 3386 |
Страны | Города | Организации | Всё → |
№ | Пользователь | Вклад |
---|---|---|
1 | cry | 167 |
2 | Um_nik | 163 |
3 | maomao90 | 162 |
3 | atcoder_official | 162 |
5 | adamant | 159 |
6 | -is-this-fft- | 158 |
7 | awoo | 157 |
8 | TheScrasse | 154 |
9 | Dominater069 | 153 |
9 | nor | 153 |
Problem link : https://codeforces.net/contest/1620/problem/C
Submission link : https://codeforces.net/contest/1620/submission/162394549
Название |
---|
a[i+1] out of bounds.
This won't happen because before that there is an or statement i+1 == n, when this will be true the a[i+1] statement will never run.
Have you noticed $$$x \le 10^{18}$$$?
Your code seems to have a lot of issues, I just fixed it for runtime errors.
Shadowed declaration
string a;
andauto mul = [&] (int a, int b)
.Can be divide by 0
int t = x/prod[i];
.What if prod is empty
prod.back() = 1;
Can be accessed out of bound
forn(_, take[i])
Can be overflow
int ans = A * b;
Thanks for replying. This prod[i] cannot be zero. I fixed the prod.back.
forn(_, take[i])
canot overflowI have handled overflow using the gfg method. Is not this corrrect?
I am not reviewing your logic, I just pointing out some code that has a potential runtime error.
I see you create vector here with size of vector "cnt"
vi prod(sz(cnt));
. If cnt is an empty vector, prod is also an empty vector.In problem constraint, k can be zero, cur always 0 so
cnt
will have no elementprod
is empty at this point andprod.back()
will give an errorIn this code
forn(_, take[i])
, I see that you increasei
in the outter loop and try to access the elementtake[i]
without checking the size which can be out of bound. A counter-example would bek = 0
-> vectortake
is empty ->take[i]
will give an error.This is a submission link that I try to fix your runtime error Submission. The overflow still exists, I don't know what method you use to handled overflow but it seems not working
https://godbolt.org/z/7PvxGxKxK
Notice that compiler generate just
imul
instruction.In c++ integer overflow (
int ans = a * b
) is UB. And because it is UB, compiler think "whyb == 0 || ans / b == a
would not be true?" and just not generate such instructions.Now its MLE:) 162639237